code-corps / code-corps/code-corps-ember
Add client filtering of conversation part types for authorized users
- 主要語言
- JavaScript
- 星號
- 120
- 分支
- 75
- PR 合併指標
- 30 天內沒有已合併 PR
描述
# Problem
Add the ability for authorized users (admin) to filter by conversation part type.
This is currently blocked by 1638 and 1689.
# Add client-filtering of parts based on authorizaton
Wrap non-comment parts in the conversation thread under a `{{#if canAdminister project}}` helper, to hide non-comment parts from users who aren't admins on project.
## Add integration tests to support this change
Render a thread with one of each supported part type, register a fake project ability with `canAdminister: true`
Render a thread with one of each supported part type ,register a fake project ability with `canAdminister: false`, see if just the comment part is rendered
See `tests/integration/components/task-assignment-test.js` on how to register a fake ability
## References #1636 #1638, #1689
Progress on: #1597
貢獻指南
研究方向
先查看阻塞項 #1638 和 #1689,然後以 tests/integration/components/task-assignment-test.js 作為註冊 fake ability 的參考。為包含每種受支援 part type 的 thread 新增整合測試覆蓋,並分別測試 canAdminister 為 true 和 false 的情況;完成標準是 admins 能看到所有 parts,而 non-admins 只能看到 comments。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript
- 領域
- frontend
- Issue 類型
- 功能
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100