code-corps / code-corps/code-corps-ember

Add client filtering of conversation part types for authorized users

Abierto
#1,692 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
120
Forks
75
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

# Problem

Add the ability for authorized users (admin) to filter by conversation part type.

This is currently blocked by 1638 and 1689.

# Add client-filtering of parts based on authorizaton
Wrap non-comment parts in the conversation thread under a `{{#if canAdminister project}}` helper, to hide non-comment parts from users who aren't admins on project.

## Add integration tests to support this change
Render a thread with one of each supported part type, register a fake project ability with `canAdminister: true`
Render a thread with one of each supported part type ,register a fake project ability with `canAdminister: false`, see if just the comment part is rendered
See `tests/integration/components/task-assignment-test.js` on how to register a fake ability

## References #1636 #1638, #1689

Progress on: #1597

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.