code-corps / code-corps/code-corps-api

Step through policies for projects, organizations, memberships

Đang mở
#725 0 bình luận 0 reaction 2 người được giao Được @joshsmith nhận Xem trên GitHub
Ngôn ngữ chính
Elixir
Star
234
Fork
82
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

# Problem

This part of our system is probably the complex and I'm not sure it was properly finalized.
Now that we're switching from `OrganizationMembership` to a `ProjectUser` + `:owner` system, we need to step through and figure out exactly how it should work.

# For projects

## Who can edit project information - just owner, members?

Once we merge #735, organization owners will be able to create projects. Project owners and project admin members will be able to update information. Is this correct?

## Who can manage project associations - skills, categories

Once we merge #735, this will be owners and admins. Is this correct?

## Who can manage project memberships, how do they compare to one another based on role

This definitely needs some work. Our current `ProjectUserPolicy` checks against the acting user's `ProjectUser` record, but does not check if the acting user is the outright project owner.

## What roles do we have?

Should we still keep the "owner" role, or should we exclusively check the `owner_id` on the project? Are the two ever different? If we are keeping the role, we need to make sure everything is properly associated upon project creation and a role is created.

# For organizations

Do we expect a case where some user is a project owner, but they are not the associated organization's owner?

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.