code-corps / code-corps/code-corps-api

RFC: Merge project `approved` and `approval_requested` flags into a single field

未关闭
#1,279 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
needs clarification needs estimate RFC
主要语言
Elixir
星标
234
派生
82
PR 合并指标
30 天内没有已合并 PR

描述

# Problem

Looking at these two fields, it really seems they serve a singular purpose.
```Elixir
# A project is created
`approved: false, approval_requested: false`
# User submits project for approval
`approved: false, approval_requested: true`
# Admin approves project
`approved: true, approval_requested :does_not_matter`
```

A single field, for example,

```Elixir
# 'created' -> 'pending_approval' -> 'approved'
field :onboarding_status, :string, null: false, default: 'created'
```

Might serve our purposes much better.

We could add an additional status of `rejected` later, with an additional field of `rejected_reason` or something.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。