code-corps / code-corps/code-corps-api

RFC: Merge project `approved` and `approval_requested` flags into a single field

Aperta
#1,279 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
needs clarification needs estimate RFC
Lingua principale
Elixir
Stelle
234
Fork
82
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Problem

Looking at these two fields, it really seems they serve a singular purpose.
```Elixir
# A project is created
`approved: false, approval_requested: false`
# User submits project for approval
`approved: false, approval_requested: true`
# Admin approves project
`approved: true, approval_requested :does_not_matter`
```

A single field, for example,

```Elixir
# 'created' -> 'pending_approval' -> 'approved'
field :onboarding_status, :string, null: false, default: 'created'
```

Might serve our purposes much better.

We could add an additional status of `rejected` later, with an additional field of `rejected_reason` or something.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.