cockroachdb / cockroachdb/errors

Require a context in assertion errors

Open
#18 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
2.5k
Forks
74
PR merge metrics
No merged PRs in 30d

Description

Suggested by @andreimatei in https://github.com/cockroachdb/cockroach/pull/43032#pullrequestreview-334181315:

`AssertionFailedf` is usually called in functions with a `context.Context` available.

It would be beneficial to capture the context tags to provide more details during troubleshooting.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating AssertionFailedf and the functions that call it with a context.Context. Trace how assertion errors are constructed and how context tags are available there. Done means assertion errors consistently require or receive the context and include its tags for troubleshooting, with coverage for the updated behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.