cockroachdb / cockroachdb/activerecord-cockroachdb-adapter

Currently no support for indexes that utilize `STORING`

オープン
#282 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
Ruby
スター
105
フォーク
56
平均マージ
9時間 5分
マージ済み PR(30日)
3

説明

Currently it is only possible to specify the columns that need to be stored in an index using the regular [`add_index`](https://api.rubyonrails.org/v7.0.6/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_index) method. We therefore resort to [`execute`](https://api.rubyonrails.org/v7.0.6/classes/ActiveRecord/ConnectionAdapters/DatabaseStatements.html#method-i-execute) statements like the following:

```
CREATE INDEX "users_lastname_asc"
ON users (last_name ASC)
STORING (first_name, company_id);
```

This will however add an index declaration to the `schema.rb` that reads as follow:

```
t.index ["last_name", "first_name", "company_id"], name: "users_lastname_asc"
```

This seems like an implementation detail leaking into the `schema.rb`: Obviously the stored columns are part of the index, but to the best of my understanding they are not contributing to the lookup data structures. So the `schema.rb` is now expressing something different than the actual migration.

tl;dr: Please ...
- [ ] Support `STORING` in `add_index`
- [ ] Support indices created using `STORING` in `schema.rb`

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。