cloudposse / cloudposse/github-commenter
Command help can expose sensitive credentials
- Langage dominant
- Go
- Étoiles
- 112
- Forks
- 17
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
If sensitive parameters (e.g. GitHub access token) is passed by environment variable, then the help page includes this information as a "default" value. Sensitive values should not be exposed here, in case a mistake causes the help page to be displayed.
e.g.
```
...
-token string
Github access token (default "01234567890abcdef")
...
2020/05/07 16:29:56 -sha or GITHUB_COMMIT_SHA required
```
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Start by locating the command help generation and the environment-backed flag handling, then reproduce the issue with a token supplied through an environment variable. Done means the help output no longer displays sensitive values as defaults while still showing the flag description.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- github, go
- Domaine
- cli, security
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100