cloudposse / cloudposse/github-commenter
Command help can expose sensitive credentials
- Lenguaje dominante
- Go
- Estrellas
- 112
- Forks
- 17
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
If sensitive parameters (e.g. GitHub access token) is passed by environment variable, then the help page includes this information as a "default" value. Sensitive values should not be exposed here, in case a mistake causes the help page to be displayed.
e.g.
```
...
-token string
Github access token (default "01234567890abcdef")
...
2020/05/07 16:29:56 -sha or GITHUB_COMMIT_SHA required
```
Guía de contribución
Línea de trabajo
Start by locating the command help generation and the environment-backed flag handling, then reproduce the issue with a token supplied through an environment variable. Done means the help output no longer displays sensitive values as defaults while still showing the flag description.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- github, go
- Área
- cli, security
- Tipo de issue
- Error
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100