cloudposse / cloudposse/github-commenter

Command help can expose sensitive credentials

Open
#16 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
112
Forks
17
PR merge metrics
No merged PRs in 30d

Description

If sensitive parameters (e.g. GitHub access token) is passed by environment variable, then the help page includes this information as a "default" value. Sensitive values should not be exposed here, in case a mistake causes the help page to be displayed.

e.g.
```
...
-token string
Github access token (default "01234567890abcdef")
...
2020/05/07 16:29:56 -sha or GITHUB_COMMIT_SHA required
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.