cloudinary / cloudinary/cloudinary_gem
uploader.read returns an empty string
- 主要言語
- Ruby
- スター
- 420
- フォーク
- 285
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
I use cloudinary 1.1.0 with carrierwave 0.10.0 in a rails 4.2.4 app to store PDFs.
I get the following bug
``` ruby
record.pdf.read # => ""
```
I digged a bit into the code base and realised that the Uploader's identifier was not the same as the Cloudinary::CarrierWave::CloudinaryFile's identifier
``` ruby
record.pdf.identifier # => v1444643650/foo.pdf
record.pdf.file.identifier # => image/upload/v1444643650/foo.pdf
```
Internally, pdf.read calls pdf.file.read which is defined as
``` ruby
def read(options={})
parameters={:type=>self.storage_type, :resource_type=>self.resource_type}.merge(options)
Cloudinary::Downloader.download(self.identifier, parameters)
end
```
Cloudinary::Downloader.download then gives Cloudinary::Utils.cloudinary_url the passed identifier to generate the URL to read data from.
But the generated URL is wrong when the identifier is pdf.file.identifer. I tried with the uploader's identifier and it worked.
``` ruby
Cloudinary::Utils.cloudinary_url pdf.identifier
# => http://res.cloudinary.com/cloud_name/image/upload/v1444643650/foo.pdf
Cloudinary::Utils.cloudinary_url pdf.file.identifier
# => http://res.cloudinary.com/cloud_name/image/upload/v1/image/upload/v1444643650/foo.pdf
```
Hope this helps to fix the bug
コントリビューションガイド
評価
この issue はまだ評価されていません。