chipsalliance / chipsalliance/Surelog

Incorrect cmake installation instructions fail to install files into the stage directory

Open
#3,963 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
475
Forks
90
Avg merge
1h 39m
Merged PRs (30d)
37

Description

In case when installation is done into a stage directory instructions like [this](https://github.com/chipsalliance/Surelog/blob/master/CMakeLists.txt#L773) fail to install files.

Custom commands can't properly install files.

The reason is that the stage directory is only given to the cmake backend (either GNU make or Ninja) as the ```DESTDIR``` environment variable. This value isn't known at the cmake time, so such instructions can't possibly install files into proper destinations under the stage directory.

Proposed solution: Custom commands should build files in the build directory. Then cmake's ```install``` commands should be used to install such files into proper destinations under the stage directory.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.