chipsalliance / chipsalliance/Surelog

FindANTLR.cmake: should also look in `$CLASSPATH`

Open
#3,551 3 comments 0 reactions 1 assignee Claimed by @timkpaine View on GitHub
Dominant language
C++
Stars
475
Forks
90
Avg merge
1h 39m
Merged PRs (30d)
37

Description

The `cmake/modules/FindANTLR.cmake` looks in a few hard-coded well-known locations for a potential antlr*complete.jar.

https://github.com/chipsalliance/Surelog/blob/edb409a1f730d59665c312551aadc0f76af1c82e/cmake/modules/FindANTLR.cmake#L13-L21

However, that is not necessarily where the file is.
It would be good if it was also consulting the `CLASSPATH` (arguably, it even should look there _first_ before going into guess-mode rummaging through directories).

While at it, looking for exactly version 4.12.0 is very specific, can we change that to 4.12.* to be future compatible in case there are new patchlevels coming out ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.