caolan / caolan/nodeunit

make test on fresh clone failes due to undeclared dependencies

Open
#351 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.9k
Forks
359
PR merge metrics
No merged PRs in 30d

Description

# Steps to reproduce

```
git clone https://github.com/caolan/nodeunit.git
cd nodeunit
make test
```

# Expected behaviour

All tests pass

# Actual behaviour

```
nodejs ./bin/nodeunit test
module.js:471
throw err;
^

Error: Cannot find module 'ejs'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/home/matthew/Documents/Projects/nodeunit/nodeunit/lib/reporters/junit.js:18:11)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
Makefile:148: recipe for target 'test' failed
make: *** [test] Error 1
```

# Commentary

The make script should run `npm install ejs` and `npm install should`, since those are dependencies.

I'm new to nodejs and Make files, so I'm not quite sure how to do this.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Makefile test target around line 148 and inspect how dependencies are declared or installed. Reproduce the fresh-clone failure, account for the missing ejs and should dependencies, and confirm that make test passes without manual installation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.