caolan / caolan/nodeunit

'make test' and 'make lint' show errors after fresh clone on system

オープン
#313 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
1.9k
フォーク
359
PR マージ指標
30日以内にマージされた PR はありません

説明

Hello,
I recently cloned the repository and run the commands 'make test' and 'make lint'. Both the commands show errors :
Output of both the commands,

prateek@prateek:~/codes/nodeunit$ make test
node ./bin/nodeunit test

test-base
✔ testCalled
✔ testOk
✔ testEquals
✔ testSame
✔ testEqual
✔ testNotEqual
✔ testDeepEqual
✔ testNotDeepEqual
✔ testStrictEqual
✔ testNotStrictEqual
✔ testThrows
✔ testThrowsWithReGex
✔ testThrowsWithErrorValidation
✔ testDoesNotThrows
✔ testIfError
✔ testExpect

test-bettererrors
✖ testEqual

AssertionError: expected [String: 'AssertionError\n at Object.exports.testEqual (/home/prateek/codes/nodeunit/test/test-bettererrors.js:29:16)\n at Object. (/home/prateek/codes/nodeunit/lib/core.js:236:16)\n at /home/prateek/codes/nodeunit/lib/core.js:236:16\n at Object.exports.runTest (/home/prateek/codes/nodeunit/lib/core.js:70:9)\n at /home/prateek/codes/nodeunit/lib/core.js:118:25\n at /home/prateek/codes/nodeunit/deps/async.js:513:13\n at iterate (/home/prateek/codes/nodeunit/deps/async.js:123:13)\n at async.forEachSeries (/home/prateek/codes/nodeunit/deps/async.js:139:9)\n at _concat (/home/prateek/codes/nodeunit/deps/async.js:512:9)\n at Object.concatSeries (/home/prateek/codes/nodeunit/deps/async.js:152:23)'] to include 'true'
at Object.Assertion.include (/home/prateek/codes/nodeunit/node_modules/should/lib/should.js:479:10)
at Object.exports.testEqual (/home/prateek/codes/nodeunit/test/test-bettererrors.js:33:34)
at Object. (/home/prateek/codes/nodeunit/lib/core.js:236:16)
at /home/prateek/codes/nodeunit/lib/core.js:236:16
at Object.exports.runTest (/home/prateek/codes/nodeunit/lib/core.js:70:9)
at /home/prateek/codes/nodeunit/lib/core.js:118:25
at /home/prateek/codes/nodeunit/deps/async.js:513:13
at iterate (/home/prateek/codes/nodeunit/deps/async.js:123:13)
at async.forEachSeries (/home/prateek/codes/nodeunit/deps/async.js:139:9)
at _concat (/home/prateek/codes/nodeunit/deps/async.js:512:9)

✔ testAssertThrows
✔ testErrorIsNotAssertion

test-cli
✔ run test suite using absolute path

test-failing-callbacks
✔ testFailingLog
✔ testFailingTestDone
✔ testAssertionObj
✔ testLogOptional
✔ testExpectWithFailure

test-httputil
(node) http.createClient is deprecated. Use http.request instead.
✔ testHttpUtilBasics
✔ testHttpUtilJsonHandling

test-runfiles
✔ testRunFiles
✔ testRunFilesEmpty
✖ testEmptyDir

TypeError: path.exists is not a function
at Object.exports.testEmptyDir (/home/prateek/codes/nodeunit/test/test-runfiles.js:119:10)
at Object. (/home/prateek/codes/nodeunit/lib/core.js:236:16)
at /home/prateek/codes/nodeunit/lib/core.js:236:16
at Object.exports.runTest (/home/prateek/codes/nodeunit/lib/core.js:70:9)
at /home/prateek/codes/nodeunit/lib/core.js:118:25
at /home/prateek/codes/nodeunit/deps/async.js:513:13
at iterate (/home/prateek/codes/nodeunit/deps/async.js:123:13)
at /home/prateek/codes/nodeunit/deps/async.js:134:25
at /home/prateek/codes/nodeunit/deps/async.js:515:17
at Immediate._onImmediate (/home/prateek/codes/nodeunit/lib/types.js:146:17)

test-runmodule
✔ testRunModule
✔ testRunModuleTestSpec
✔ testRunModuleEmpty
✔ testNestedTests

test-runtest
✔ testArgs
✔ testDoneCallback
✔ testThrowError

test-sandbox
✔ testSimpleSandbox
✔ testSandboxContext
✔ testSandboxMultiple

test-testcase
✔ testTestCase
✔ tearDownAfterError
✔ catchSetUpError
✔ setUpErrorCallback
✔ catchTearDownError
✔ tearDownErrorCallback
✔ testErrorAndtearDownError
✔ testCaseGroups
✔ nestedTestCases
✔ deepNestedTestCases

test-testcase-legacy
✔ testTestCase
✔ tearDownAfterError
✔ catchSetUpError
✔ setUpErrorCallback
✔ catchTearDownError
✔ tearDownErrorCallback
✔ testErrorAndtearDownError
✔ testCaseGroups
✔ nestedTestCases
✔ deepNestedTestCases

FAILURES: 2/217 assertions failed (276ms)
make: **\* [test] Error 1

prateek@prateek:~/codes/nodeunit$ make lint
nodelint --config nodelint.cfg ./index.js ./bin/nodeunit ./bin/nodeunit.json ./lib/_.js ./lib/reporters/_.js ./test/*.js
undefined:2557
s.string = s;
^

TypeError: Cannot assign to read only property 'string' of (begin)
at ultimate (eval at (/opt/node/lib/node_modules/nodelint/nodelint:46:11), :2557:18)
at eval (eval at (/opt/node/lib/node_modules/nodelint/nodelint:46:11), :3167:5)
at eval (eval at (/opt/node/lib/node_modules/nodelint/nodelint:46:11), :6399:2)
at /opt/node/lib/node_modules/nodelint/nodelint:46:3
at Object. (/opt/node/lib/node_modules/nodelint/nodelint:194:2)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Function.Module.runMain (module.js:441:10)
make: **\* [lint] Error 1

System configuration :
Ubuntu 14.04, 64 bit

Node version : 4.4.1
NPM version : 2.14.20

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

報告されている Node 4.4.1 で Make ターゲットを再現することから始め、test/test-bettererrors.js と test/test-runfiles.js を調べて、失敗している 2 つのアサーションを確認します。次に、make lint で示される nodelint の呼び出しを確認します。サポート対象の新規 clone のセットアップで make test と make lint が正常に完了すれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript, node.js
領域
build-system, testing-qa, tooling
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
説明が足りない
初心者へのやさしさ
25/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。