callstack / callstack/react-native-paper
Menu component showing scrollbar indicator
- 主要语言
- TypeScript
- 星标
- 14.5k
- 派生
- 2.2k
- 平均合并
- 5 天 23 小时
- 30 天内合并 PR
- 12
描述
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-native-paper@5.12.3` for the project I'm working on.
🔺️🔺️🔺️ Adding showsVerticalScrollIndicator to Menu component does not disable the scrollbar indicator 🔺️🔺️🔺️
Here is the diff that solved my problem:
```diff
diff --git a/node_modules/react-native-paper/src/components/Menu/Menu.tsx b/node_modules/react-native-paper/src/components/Menu/Menu.tsx
index 82fbdf4..8632b98 100644
--- a/node_modules/react-native-paper/src/components/Menu/Menu.tsx
+++ b/node_modules/react-native-paper/src/components/Menu/Menu.tsx
@@ -663,6 +663,7 @@ class Menu extends React.Component {
{(scrollableMenuHeight && (
{children}
```
This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).
贡献指南
调研方向
从 src/components/Menu/Menu.tsx 开始,检查 Menu 具有可滚动高度时使用的 ScrollView。以提供的 diff 作为预期行为:Menu 不应再显示垂直滚动条指示器。检查 repository 中现有的 Menu 覆盖情况(如果有),并在支持的平台上验证该行为。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react-native, typescript
- 领域
- mobile
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 58/100