callstack / callstack/react-native-paper

Menu component showing scrollbar indicator

Open
#4,811 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14.5k
Forks
2.2k
Avg merge
5d 23h
Merged PRs (30d)
12

Description

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used [patch-package](https://github.com/ds300/patch-package) to patch `react-native-paper@5.12.3` for the project I'm working on.

🔺️🔺️🔺️ Adding showsVerticalScrollIndicator to Menu component does not disable the scrollbar indicator 🔺️🔺️🔺️

Here is the diff that solved my problem:

```diff
diff --git a/node_modules/react-native-paper/src/components/Menu/Menu.tsx b/node_modules/react-native-paper/src/components/Menu/Menu.tsx
index 82fbdf4..8632b98 100644
--- a/node_modules/react-native-paper/src/components/Menu/Menu.tsx
+++ b/node_modules/react-native-paper/src/components/Menu/Menu.tsx
@@ -663,6 +663,7 @@ class Menu extends React.Component {
{(scrollableMenuHeight && (

{children}

```

This issue body was [partially generated by patch-package](https://github.com/ds300/patch-package/issues/296).

Contributor guide

Open the contributing guide

Research direction

Start in src/components/Menu/Menu.tsx and inspect the ScrollView used when the menu has a scrollable height. Use the supplied diff as the expected behavior: the Menu should no longer show the vertical scrollbar indicator. Check the repository’s existing Menu coverage, if available, and verify the behavior on the supported platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.