callstack / callstack/react-native-paper

Cannot increase Button label's font size without throwing off labels vertical alignment

Abierto
#4,695 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
14.5k
Forks
2.2k
Merge medio
5 d 23 h
PR fusionados (30 d)
12

Descripción

### Current behaviour
The button labels font size doesn't scale for large devices, you have a tiny label that looks unlike anything else on the screen... you can't increase the font size or the vertical alignment of the label is lost.
We tried patching this ourselves but the button itself is coded like a complete rats nest, full of magic numbers and strange floating views layed on top of other views. Why this is needed for a button that still doesn't work remains a mystery but perhaps the framework designers can figure it out.

Adjusting the button height does nothing to fix the vertical alignment either.
Ideally we'd like to be able to increase the button height AND increase the font size, but we could live with thin frail buttons if their labels just looked semi-normal.

We'd even settle for react-native-paper resizing the label itself, and providing a simple size prop i.e. "large" | "medium" | "small". Really we'd be okay with anything better than what we currently have.

![Image](https://github.com/user-attachments/assets/94ea8b15-3730-4ee5-a44a-57f9dc01720e)

As of now we're not even using react-native-paper's buttons since they make the entire app look sloppily done on any large device. Which these days is most devices. But this means we now have 2 UI frameworks installed, one for a simple button and the other for everything else.

### Expected behaviour
Just a simple button that looks normal on different devices.

### How to reproduce?
Create any project and add a button to it. Try making it look normal on large devices. You can't.

### What have you tried so far?
It's not my job to provide basic functionality

### Your Environment
It's not an environment problem.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Reproduzca el problema creando un proyecto, añadiendo un botón de react-native-paper y probando cambios en el tamaño de fuente de la etiqueta y en la altura del botón en un dispositivo grande. El issue no menciona archivos fuente ni pruebas; el trabajo está completo cuando la etiqueta del botón permanece alineada verticalmente, mientras el botón y la etiqueta pueden redimensionarse en distintos dispositivos.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
react-native
Área
frontend, mobile
Tipo de issue
Error
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.