callstack / callstack/react-native-paper

Cannot increase Button label's font size without throwing off labels vertical alignment

Offen
#4,695 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
TypeScript
Sterne
14.5k
Forks
2.2k
Ø Merge
5 T. 23 Std.
Gemergte PRs (30 T.)
12

Beschreibung

### Current behaviour
The button labels font size doesn't scale for large devices, you have a tiny label that looks unlike anything else on the screen... you can't increase the font size or the vertical alignment of the label is lost.
We tried patching this ourselves but the button itself is coded like a complete rats nest, full of magic numbers and strange floating views layed on top of other views. Why this is needed for a button that still doesn't work remains a mystery but perhaps the framework designers can figure it out.

Adjusting the button height does nothing to fix the vertical alignment either.
Ideally we'd like to be able to increase the button height AND increase the font size, but we could live with thin frail buttons if their labels just looked semi-normal.

We'd even settle for react-native-paper resizing the label itself, and providing a simple size prop i.e. "large" | "medium" | "small". Really we'd be okay with anything better than what we currently have.

![Image](https://github.com/user-attachments/assets/94ea8b15-3730-4ee5-a44a-57f9dc01720e)

As of now we're not even using react-native-paper's buttons since they make the entire app look sloppily done on any large device. Which these days is most devices. But this means we now have 2 UI frameworks installed, one for a simple button and the other for everything else.

### Expected behaviour
Just a simple button that looks normal on different devices.

### How to reproduce?
Create any project and add a button to it. Try making it look normal on large devices. You can't.

### What have you tried so far?
It's not my job to provide basic functionality

### Your Environment
It's not an environment problem.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Reproduce the issue by creating a project, adding a react-native-paper button, and testing label font-size and button-height changes on a large device. The issue names no source files or tests; the work is complete when the button label remains vertically aligned while the button and label can be resized across devices.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
react-native
Bereich
frontend, mobile
Issue-Typ
Bug
Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
25/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.