callstack / callstack/react-native-paper

CheckboxAndroid and CheckboxIOS use MaterialCommunityIcon instead of custom icon function from PaperProvider

Ouverte
#4,255 5 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
TypeScript
Étoiles
14.5k
Forks
2.2k
Merge moyen
5 j 23 h
PR mergées (30 j)
12

Description

### Current behaviour

I have setup a custom icon in PaperProvider

```
import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome';
...

}}>
// ...

```

But `CheckboxAndroid` and `CheckboxIOS` only use `MaterialCommunityIcon` instead of the icon function from the `PaperProvider`

https://github.com/callstack/react-native-paper/blob/d6b6b667dec9d9d47a8e7ad3afbbd48289b31971/src/components/Checkbox/CheckboxAndroid.tsx#L135

### Expected behaviour
`CheckboxAndroid` and `CheckboxIOS` should use [`Icon`](https://github.com/callstack/react-native-paper/blob/main/src/components/Icon.tsx) instead of `MaterialCommunityIcon` for the check icons.

### How to reproduce?

https://snack.expo.dev/@jahirfiquitiva/greedy-yellow-turkish-delight

### Preview

### What have you tried so far?

### Your Environment

| software | version
| --------------------- | -------
| ios | 17.0.1
| android | x
| react-native | 0.72.6
| react-native-paper | 5.11.6
| node | v18.18.2
| npm or yarn | 4.0.1
| expo sdk | x.x.x

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.