callstack / callstack/react-native-paper

CheckboxAndroid and CheckboxIOS use MaterialCommunityIcon instead of custom icon function from PaperProvider

Open
#4,255 5 comments 2 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
14.5k
Forks
2.2k
Avg merge
5d 23h
Merged PRs (30d)
12

Description

### Current behaviour

I have setup a custom icon in PaperProvider

```
import {FontAwesomeIcon} from '@fortawesome/react-native-fontawesome';
...

}}>
// ...

```

But `CheckboxAndroid` and `CheckboxIOS` only use `MaterialCommunityIcon` instead of the icon function from the `PaperProvider`

https://github.com/callstack/react-native-paper/blob/d6b6b667dec9d9d47a8e7ad3afbbd48289b31971/src/components/Checkbox/CheckboxAndroid.tsx#L135

### Expected behaviour
`CheckboxAndroid` and `CheckboxIOS` should use [`Icon`](https://github.com/callstack/react-native-paper/blob/main/src/components/Icon.tsx) instead of `MaterialCommunityIcon` for the check icons.

### How to reproduce?

https://snack.expo.dev/@jahirfiquitiva/greedy-yellow-turkish-delight

### Preview

### What have you tried so far?

### Your Environment

| software | version
| --------------------- | -------
| ios | 17.0.1
| android | x
| react-native | 0.72.6
| react-native-paper | 5.11.6
| node | v18.18.2
| npm or yarn | 4.0.1
| expo sdk | x.x.x

Contributor guide

Open the contributing guide

Research direction

Start with the CheckboxAndroid.tsx location linked in the issue, then inspect CheckboxIOS and src/components/Icon.tsx. Verify how the custom PaperProvider icon function is accessed and confirm that both checkbox components use it for their check icons. Done means the provided FontAwesome icon renders for checkboxes on Android and iOS.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.