callstack / callstack/react-native-ios-kit

Styling improvements for landing page

オープン
#181 コメント 5 件 リアクション 0 件 担当者 1 名 @Jy411 が担当を希望しています GitHub で見る
📖 Docs
主要言語
JavaScript
スター
555
フォーク
52
PR マージ指標
30日以内にマージされた PR はありません

説明

## Describe the feature

Improvements to the [landing page](https://callstack.github.io/react-native-ios-kit/) styling

Stuff that feels improvable:

1. In the dark mode this dark seem practically black when set against the white screenshot - would make it a bit lighter

Screenshot 2020-05-13 at 14 27 40

2. On the most left and right item the margin between it and side of the page seems a bit too small - even smaller than e.g. between the right menu options

Screenshot 2020-05-13 at 14 27 50

3. These 0 px border radius corners seem very sharp when set aside the very rounded borders of the code block. Maybe add a tiny border radius to reduce the contrast?

Screenshot 2020-05-13 at 14 28 14

4. Maybe make these headlines either larger or bolded? They don't stand out that much from the paragraph right now.

Screenshot 2020-05-13 at 14 28 23

5. More bottom padding here? The tiny QR code seems to be shoved to the bottom by the vastness of the black background (# poetic)

Screenshot 2020-05-13 at 14 28 35

6. Definitely more margin between the items and Callstack logo

Screenshot 2020-05-13 at 14 28 45

And finally: 7. This `Get started` button seems to be placed a bit randomly, isn't?

Screenshot 2020-05-13 at 14 36 07

## Motivation

It could look a bit better. Wdyt?

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。