bramp / bramp/ffmpeg-cli-wrapper

Allow user to replace all uses of STDOUT/STDERR for logging

Ouverte
#355 4 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Java
Étoiles
1.9k
Forks
424
Merge moyen
5 h 35 min
PR mergées (30 j)
2

Description

Hello,

I deploy this library in an environment where the java processes stdout and stderr is discarded and there is no way for the developer
maintainer to see it.

I would like the ffmpeg errors to be captured without involving stderr as they are usefull to diagnose some errors.
To capture the errors you would need to either log them into java.util.logging or the slf4j logging facade.

I understand that you may not wish to include slf4j as a dependency.
I know that some people hate java.util.logging (and would prefer not to have to use it)

So my suggestion would be to have a global static variable that the user can set that determines where log lines get pumped to.
The default implementation would pump to stdout/stderr just like it currently does but I could then in my bootstrap of my application call
"FFmpegCommon.setLoggingSystem(FFmpegLoggingManager instance)" (just an example)

If I were to design this interface then I would give it only 1 method that looks like this:

void appendLog(Process ffmpegProc, boolean isStdErr, byte[] data, int off, int len);

If you do not want to hand in the process then please pass some unique identifier (aka process pid for example or a random UUID instead so I can tell appart error messages from multiple concurrent ffmpeg jobs)

I would outsource line breaks and all that thing to concrete implementations.
Currently I have to hack very deep into your library using inheritance to be able to accomplish this.

The default implementation that dumps everything to stdout/stderr could probably be as simple as this:

```java
public void appendLog(Process ffmpegProc, boolean isStdErr, byte[] data, int off, int len) {
PrintStream stream = isStdErr ? System.err : System.out;
try {
stream.write(data, off, len);
} catch(Exception e) {
//IGNORED
}
}
```

Sincerely
Alexander Schütz

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Commencez par localiser les chemins de code qui écrivent la sortie du processus FFmpeg vers System.out et System.err, y compris les hooks d’héritage actuellement nécessaires à la personnalisation. Utilisez FFmpegCommon.setLoggingSystem et l’interface appendLog comme point d’entrée de la conception ; le travail est terminé lorsque les appelants peuvent rediriger les deux flux tout en conservant le comportement par défaut.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
java
Domaine
cli, tooling
Type d'issue
Fonctionnalité
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
45/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.