bramp / bramp/ffmpeg-cli-wrapper
Allow user to replace all uses of STDOUT/STDERR for logging
- Lenguaje dominante
- Java
- Estrellas
- 1.9k
- Forks
- 424
- Merge medio
- 5 h 35 min
- PR fusionados (30 d)
- 2
Descripción
Hello,
I deploy this library in an environment where the java processes stdout and stderr is discarded and there is no way for the developer
maintainer to see it.
I would like the ffmpeg errors to be captured without involving stderr as they are usefull to diagnose some errors.
To capture the errors you would need to either log them into java.util.logging or the slf4j logging facade.
I understand that you may not wish to include slf4j as a dependency.
I know that some people hate java.util.logging (and would prefer not to have to use it)
So my suggestion would be to have a global static variable that the user can set that determines where log lines get pumped to.
The default implementation would pump to stdout/stderr just like it currently does but I could then in my bootstrap of my application call
"FFmpegCommon.setLoggingSystem(FFmpegLoggingManager instance)" (just an example)
If I were to design this interface then I would give it only 1 method that looks like this:
void appendLog(Process ffmpegProc, boolean isStdErr, byte[] data, int off, int len);
If you do not want to hand in the process then please pass some unique identifier (aka process pid for example or a random UUID instead so I can tell appart error messages from multiple concurrent ffmpeg jobs)
I would outsource line breaks and all that thing to concrete implementations.
Currently I have to hack very deep into your library using inheritance to be able to accomplish this.
The default implementation that dumps everything to stdout/stderr could probably be as simple as this:
```java
public void appendLog(Process ffmpegProc, boolean isStdErr, byte[] data, int off, int len) {
PrintStream stream = isStdErr ? System.err : System.out;
try {
stream.write(data, off, len);
} catch(Exception e) {
//IGNORED
}
}
```
Sincerely
Alexander Schütz
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Comience por localizar las rutas de código que escriben la salida del proceso FFmpeg en System.out y System.err, incluidos los hooks de herencia que actualmente se necesitan para la personalización. Use FFmpegCommon.setLoggingSystem y la interfaz appendLog como punto de entrada del diseño; se considera terminado cuando los llamadores puedan redirigir ambos streams mientras el comportamiento predeterminado permanece sin cambios.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- cli, tooling
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100