bradcypert / bradcypert/httpspec

Investigate memory management issue with HttpRequest URLs in http_client.zig

Aperta
#11 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
Zig
Stelle
11
Fork
1
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Review and refactor how memory is managed for HttpRequest URLs, particularly in test scenarios where the deinit method tries to free global strings. Consider alternative approaches for test setups or memory management.

Reference:
```zig
// TODO: The request de-allocates the memory used by the url in the deinit method.
// Because of this, with this test, we have to dupe it or else it cant deinit a global string.
// Needing to do this is a sign that something is off here, but also newing up requests directly
// isn't really intended either. Either way, need to look into this further.
```

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.