bradcypert / bradcypert/httpspec

Investigate memory management issue with HttpRequest URLs in http_client.zig

Open
#11 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Zig
Stars
11
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Review and refactor how memory is managed for HttpRequest URLs, particularly in test scenarios where the deinit method tries to free global strings. Consider alternative approaches for test setups or memory management.

Reference:
```zig
// TODO: The request de-allocates the memory used by the url in the deinit method.
// Because of this, with this test, we have to dupe it or else it cant deinit a global string.
// Needing to do this is a sign that something is off here, but also newing up requests directly
// isn't really intended either. Either way, need to look into this further.
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.