bootc-dev / bootc-dev/bootc

bootc expects `org.opencontainers.image.version` to be set as a label, not an annotation

Ouverte
#2,136 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
2.3k
Forks
230
Merge moyen
3 j 12 h
PR mergées (30 j)
38

Description

Hello,

I stumbled across a minor issue with the way bootc looks for an image's version (when using `bootc status`).
It expects the version to be set as a label either with the key `org.opencontainers.image.version` or with the key `version` (see [this function](https://github.com/bootc-dev/bootc/blob/b1fe5d697855189f64ba87cff5cfb058f91792f6/crates/ostree-ext/src/container/mod.rs#L605)).

However, the OpenContainers image specification only defines `org.opencontainers.image.version` as a key inside annotations (see [here](https://specs.opencontainers.org/image-spec/annotations/#pre-defined-annotation-keys)).

To match the OpenContainers spec, would it be possible to change `version_for_config` to look for `org.opencontainers.image.version` in the annotations, then look for `version` in the labels, or would this be considered too much of a breaking change?

Best regards,
François

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Start with version_for_config in crates/ostree-ext/src/container/mod.rs and compare its current label lookup with the OpenContainers annotation specification linked in the issue. Verify the behavior through bootc status using image metadata, and consider the change complete when the OCI version annotation is recognized while the existing version label remains supported.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
rust
Domaine
operating-systems
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
70/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.