bootc-dev / bootc-dev/bootc

bootc expects `org.opencontainers.image.version` to be set as a label, not an annotation

Offen
#2,136 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Rust
Sterne
2.3k
Forks
230
Ø Merge
3 T. 12 Std.
Gemergte PRs (30 T.)
38

Beschreibung

Hello,

I stumbled across a minor issue with the way bootc looks for an image's version (when using `bootc status`).
It expects the version to be set as a label either with the key `org.opencontainers.image.version` or with the key `version` (see [this function](https://github.com/bootc-dev/bootc/blob/b1fe5d697855189f64ba87cff5cfb058f91792f6/crates/ostree-ext/src/container/mod.rs#L605)).

However, the OpenContainers image specification only defines `org.opencontainers.image.version` as a key inside annotations (see [here](https://specs.opencontainers.org/image-spec/annotations/#pre-defined-annotation-keys)).

To match the OpenContainers spec, would it be possible to change `version_for_config` to look for `org.opencontainers.image.version` in the annotations, then look for `version` in the labels, or would this be considered too much of a breaking change?

Best regards,
François

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.