boostorg / boostorg/graph

tiernan_all_cycles doesn't work out of the box with adjacency_list

Aperta
#182 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
algorithm beginner friendly
Lingua principale
C++
Stelle
392
Fork
239
Merge medio
1g 11m
PR unite (30g)
20

Descrizione

there might be a bug in
`boost/graph/tiernan_all_cycles.hpp`
which comes from tiernan_all_cycles.hpp, line 161:
`BOOST_CONCEPT_ASSERT(( VertexIndexGraphConcept ));`
and then in graph_concepts.hpp on line 469/70
```
// This is relaxed
renumber_vertex_indices(g);
```

One way to make it compile is to just provide the renumber_vertex_indices the concept checks for, but since tiernan_all_cycles doesn't directly or indirectly call renumber_vertex_indices the check on line 161 in tiernan_all_cycles.hpp can also be commented out.
I don't understand why this concept check is used. Maybe it's fine and the "workaround" is the right way to deal with it?

[Here's a godbolt.](https://godbolt.org/z/rtdEZl)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.