boostorg / boostorg/graph

tiernan_all_cycles doesn't work out of the box with adjacency_list

Ouverte
#182 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
algorithm beginner friendly
Langage dominant
C++
Étoiles
392
Forks
239
Merge moyen
1 j 11 min
PR mergées (30 j)
20

Description

there might be a bug in
`boost/graph/tiernan_all_cycles.hpp`
which comes from tiernan_all_cycles.hpp, line 161:
`BOOST_CONCEPT_ASSERT(( VertexIndexGraphConcept ));`
and then in graph_concepts.hpp on line 469/70
```
// This is relaxed
renumber_vertex_indices(g);
```

One way to make it compile is to just provide the renumber_vertex_indices the concept checks for, but since tiernan_all_cycles doesn't directly or indirectly call renumber_vertex_indices the check on line 161 in tiernan_all_cycles.hpp can also be commented out.
I don't understand why this concept check is used. Maybe it's fine and the "workaround" is the right way to deal with it?

[Here's a godbolt.](https://godbolt.org/z/rtdEZl)

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.