boostorg / boostorg/graph

tiernan_all_cycles doesn't work out of the box with adjacency_list

Open
#182 4 comments 0 reactions 0 assignees View on GitHub
algorithm beginner friendly
Dominant language
C++
Stars
392
Forks
239
Avg merge
1d 11m
Merged PRs (30d)
20

Description

there might be a bug in
`boost/graph/tiernan_all_cycles.hpp`
which comes from tiernan_all_cycles.hpp, line 161:
`BOOST_CONCEPT_ASSERT(( VertexIndexGraphConcept ));`
and then in graph_concepts.hpp on line 469/70
```
// This is relaxed
renumber_vertex_indices(g);
```

One way to make it compile is to just provide the renumber_vertex_indices the concept checks for, but since tiernan_all_cycles doesn't directly or indirectly call renumber_vertex_indices the check on line 161 in tiernan_all_cycles.hpp can also be commented out.
I don't understand why this concept check is used. Maybe it's fine and the "workaround" is the right way to deal with it?

[Here's a godbolt.](https://godbolt.org/z/rtdEZl)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.