revising BGL code (isomorphism.hpp) that uses abort()
Aperta
beginner friendly
priority: low
warning
- Lingua principale
- C++
- Stelle
- 392
- Fork
- 239
- Merge medio
- 1g 11m
- PR unite (30g)
- 20
Descrizione
https://github.com/boostorg/graph/blob/887e63d34e977ae439e392282422d2b82791a730/include/boost/graph/isomorphism.hpp#L321 is an abort() call. This is a problem for interoperation with R as the static checker warns about such calls, and warnings preclude inclusion of packages in certain ecosystems.
There don't seem to be many instances of abort() in BGL code. Should it be replaced by a boost::throw_exception?
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.