boostorg / boostorg/graph

revising BGL code (isomorphism.hpp) that uses abort()

Abierto
#163 7 comentarios 0 reacciones 0 asignados Ver en GitHub
beginner friendly priority: low warning
Lenguaje dominante
C++
Estrellas
392
Forks
239
Merge medio
1 d 11 min
PR fusionados (30 d)
20

Descripción

https://github.com/boostorg/graph/blob/887e63d34e977ae439e392282422d2b82791a730/include/boost/graph/isomorphism.hpp#L321 is an abort() call. This is a problem for interoperation with R as the static checker warns about such calls, and warnings preclude inclusion of packages in certain ecosystems.

There don't seem to be many instances of abort() in BGL code. Should it be replaced by a boost::throw_exception?

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.