boostorg / boostorg/graph

revising BGL code (isomorphism.hpp) that uses abort()

Open
#163 7 comments 0 reactions 0 assignees View on GitHub
beginner friendly priority: low warning
Dominant language
C++
Stars
392
Forks
239
Avg merge
1d 11m
Merged PRs (30d)
20

Description

https://github.com/boostorg/graph/blob/887e63d34e977ae439e392282422d2b82791a730/include/boost/graph/isomorphism.hpp#L321 is an abort() call. This is a problem for interoperation with R as the static checker warns about such calls, and warnings preclude inclusion of packages in certain ecosystems.

There don't seem to be many instances of abort() in BGL code. Should it be replaced by a boost::throw_exception?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.