boostorg / boostorg/boost

Use top-level include folder for headers

Đang mở
#501 1 bình luận 2 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
HTML
Star
8.6k
Fork
1.9k
Merge trung bình
39 phút
Pull request đã merge (30 ngày)
2

Mô tả

Currently `b2 headers` puts all headers under `./boost` and adds the root folder to the include path.
In e.g. https://github.com/boostorg/config/issues/345 I argued, that only the minimum amount of stuff should be in the include path, i.e. the current practice would allow `#include ` which is odd, but possible so users might do stuff like that which they are not supposed to.
Even worse: `#include ` now works on systems with case-insensitive filesystems.

This might sound like a stretch, but such a case did appear with `VERSION` or `version` files other projects put into their root folder and added that to the include path which breaks any library prepared for the C++20 header ``, see https://github.com/boostorg/config/issues/345 for more details.

--> I propose to put the headers into `include/boost` and add the `include` folder to the include paths.

I think CMakes FindBoost would still find it, because it considers the include folder already for each searched prefix. For other projects we could still provide a top-level `boost` symlink to `include/boost` but don't use that ourselves anymore, or just drop that.

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.