bluerobotics / bluerobotics/ping-python

Add speed of sound estimation from water properties

未关闭
#125 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement good first issue
主要语言
Python
星标
60
派生
39
PR 合并指标
30 天内没有已合并 PR

描述

Would help with #122, and would also better enable data processing capabilities.

Should probably be implemented as a `water.py` module, with a helper for estimating salinity as per [here](https://bluerobotics.com/learn/speed-of-sound-in-water-calculator/#salinity-estimation). Ideally there would be some kind of API access to NASA's global sea surface salinity data (queried by GPS location?) or something, but that is probably best left as a note/TODO for now.

Example `v_sound` code at bluerobotics/ping-viewer/issues/1003

Would be useful to include an `estimate_v_sound(self, depth=None, temperature=None, salinity=None)` method in `PingDevice` that uses `water.estimate_sound_speed(depth, temperature, salinity)`, which can be updated over time to use the most up to date implemented method. `PingDevice` can have its initialisation updated to include initial `depth=0, temperature=25, salinity=water.estimate_salinity_from_type("seawater")` values.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by reviewing the existing PingDevice implementation and the proposed water.py module, then compare the example v_sound code in bluerobotics/ping-viewer/issues/1003 with the linked salinity-estimation guidance. Done means providing sound-speed and salinity estimation, exposing PingDevice.estimate_v_sound(depth, temperature, salinity), and initializing the stated defaults; NASA data access should remain a TODO.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
backend, data
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。