bigskysoftware / bigskysoftware/_hyperscript

Error location annotations don't line up when _hs source uses tabs for indentation

Aperta
#640 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
3.8k
Fork
172
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

hyperscript's error annotations (the `^^` markers) do not line up with the printed source when it uses tab characters as indentation:

Image
Image

When spaces are used in the source, the marker lines up correctly:

Image
Image

This issue is because, when the annotation creator ([`createParserContext`](https://github.com/bigskysoftware/_hyperscript/blob/455a32d30533c198cdf9a75a053c41520de04249/src/_hyperscript.js#L1311)) is figuring out where to place the marker, it counts tab characters as a single character. If, on the first example, the tab characters are replaces with single spaces, the marker lines up correctly:

Image

To solve this, either:
- Around `createParserContext`'s call to `String.repeat`, tabs would be specially-cased for the offset to count as some number of characters (4, 8, ...) rather than just one.
- Or, the whitespace before the true start of a line could be copied, where the marker offset will only counted from the "real" start of the line (iow, where the indentation ends), and afterwards the saved whitespace is prepended to the `" ".repeat(offset)`, something like
```diff
diff --git a/tmp/1 b/tmp/2
index c054964..a688d74 100644
--- a/tmp/1
+++ b/tmp/2
@@ -4,7 +4,8 @@
var lines = source.split("\n");
var line = currentToken && currentToken.line ? currentToken.line - 1 : lines.length - 1;
var contextLine = lines[line];
+ var leadingWhitespace = contextLine.match(/^\s+/)[0];
var offset = /** @type {number} */ (
currentToken && currentToken.line ? currentToken.column : contextLine.length - 1);
- return contextLine + "\n" + " ".repeat(offset) + "^^\n\n";
+ return contextLine + "\n" + leadingWhitespace + " ".repeat(offset - leadingWhitespace.length) + "^^\n\n";
}
```
This is of course a bit hacky and doesn't take into account things like tabs in the middle of a line (which solution no.1 would do correctly, and only that among other edge cases I'm not smart enough to think of), but it works fine!

Image
Image

Even with mixed indentation!

Image
Image

---

Using:
- _hyperscript 0.9.14, (originally from unpkg)
- Firefox 141.0.3
- Debian 13 `Linux 6.12.38+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.38-1 (2025-07-16) x86_64 GNU/Linux`

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Inizia da createParserContext in src/_hyperscript.js e riproduci l’output dell’annotazione con codice sorgente _hs indentato con tabulazioni, con indentazione mista e indentato con spazi. Traccia il calcolo dell’offset del marker e verifica che i marker ^^ risultanti siano allineati con la posizione nel sorgente riportata in ciascun caso.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript
Ambito
compilers
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.