bigskysoftware / bigskysoftware/_hyperscript

Error location annotations don't line up when _hs source uses tabs for indentation

Abierto
#640 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
3.8k
Forks
172
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

hyperscript's error annotations (the `^^` markers) do not line up with the printed source when it uses tab characters as indentation:

Image
Image

When spaces are used in the source, the marker lines up correctly:

Image
Image

This issue is because, when the annotation creator ([`createParserContext`](https://github.com/bigskysoftware/_hyperscript/blob/455a32d30533c198cdf9a75a053c41520de04249/src/_hyperscript.js#L1311)) is figuring out where to place the marker, it counts tab characters as a single character. If, on the first example, the tab characters are replaces with single spaces, the marker lines up correctly:

Image

To solve this, either:
- Around `createParserContext`'s call to `String.repeat`, tabs would be specially-cased for the offset to count as some number of characters (4, 8, ...) rather than just one.
- Or, the whitespace before the true start of a line could be copied, where the marker offset will only counted from the "real" start of the line (iow, where the indentation ends), and afterwards the saved whitespace is prepended to the `" ".repeat(offset)`, something like
```diff
diff --git a/tmp/1 b/tmp/2
index c054964..a688d74 100644
--- a/tmp/1
+++ b/tmp/2
@@ -4,7 +4,8 @@
var lines = source.split("\n");
var line = currentToken && currentToken.line ? currentToken.line - 1 : lines.length - 1;
var contextLine = lines[line];
+ var leadingWhitespace = contextLine.match(/^\s+/)[0];
var offset = /** @type {number} */ (
currentToken && currentToken.line ? currentToken.column : contextLine.length - 1);
- return contextLine + "\n" + " ".repeat(offset) + "^^\n\n";
+ return contextLine + "\n" + leadingWhitespace + " ".repeat(offset - leadingWhitespace.length) + "^^\n\n";
}
```
This is of course a bit hacky and doesn't take into account things like tabs in the middle of a line (which solution no.1 would do correctly, and only that among other edge cases I'm not smart enough to think of), but it works fine!

Image
Image

Even with mixed indentation!

Image
Image

---

Using:
- _hyperscript 0.9.14, (originally from unpkg)
- Firefox 141.0.3
- Debian 13 `Linux 6.12.38+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.38-1 (2025-07-16) x86_64 GNU/Linux`

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Comienza en createParserContext en src/_hyperscript.js y reproduce la salida de anotación con código fuente _hs indentado con tabulaciones, con indentación mixta y con espacios. Sigue cómo se calcula el desplazamiento del marcador y verifica que los marcadores ^^ resultantes se alineen con la ubicación de origen indicada en cada caso.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
compilers
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
48/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.