bazel-contrib / bazel-contrib/rules_python
Support adding patch_cmds in pip.override
- 主要言語
- Starlark
- スター
- 688
- フォーク
- 721
- 平均マージ
- 15時間 7分
- マージ済み PR(30日)
- 76
説明
# 🚀 feature request
### Description
Currently, the following exists for patching targets. However, for certain targets like pytorch, we have custom commands that patch the rpath of shared object libraries in our current workspace. However, this isn't doable with pip.override as we can't quite generate a patch for rpath differences. We can't patch the wheel beforehand because we're using pip torch relies on an rpath that is variable to change depending on the sha256sum of the wheel so we have to patch after the wheel is built as we can't know the sha256sum of the wheel before it's built
```
pip.override(
file = ".whl",
patch_strip = 1,
patches = [
"",
],
)
```
### Describe the solution you'd like
ideally if pip.override has a `patch_cmds` optional argument that would be great
```
pip.override(
file = ".whl",
patch_strip = 1,
patches = [
"",
],
patch_cmds = [
]
)
```
### Describe alternatives you've considered
We've tried patching before the wheel is built, but like the description above says, it's currently a chicken and egg problem
コントリビューションガイド
調査の方向性
Start by locating the pip.override entry point and the existing handling for patches and patch_strip. Trace how the wheel is processed after it is built, then determine where an optional patch_cmds argument would fit. Done means pip.override accepts and runs the commands while preserving existing patch behavior; the issue names no specific files or tests to run.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- build-system
- issue の種類
- 機能追加
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100