bazel-contrib / bazel-contrib/rules_python

PYTHONHOME gets incorrectly set by pip extension on windows

オープン
#3,294 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
type: bug type: pip
主要言語
Starlark
スター
688
フォーク
721
平均マージ
15時間 7分
マージ済み PR(30日)
76

説明

# 🐞 bug report

### Affected Rule

This affects the pip module extension

### Is this a regression?

Not that I'm aware of, but I assume it's worked on windows at some point

### Description

When using the pip extension on windows, I get crashes like:
```
Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

Current thread 0x00000c40 (most recent call first):

```

I traced this back to the `PYTHONHOME` environment variable, which is being set from the stdout of a repository_ctx.execute call. Instead of just containing the result of the command, it also appears to contain the prompt and the command itself, corrupting this load-bearing environment variable. An example of what I see:
```
Python path configuration:
PYTHONHOME = '\x0d\x0aC:\tmp\3hjz7nbt\external\rules_python~~pip~protobuf_pip_deps_311_setuptools>C:/hostedtoolcache/windows/Python/3.9.13/x64/python3.exe -B -I -c "import sys; print(f\'***sys.prefix***\', end=\'\')" \x0d\x0aC:\hostedtoolcache\windows\Python\3.9.13\x64'
```

Commenting out the line in rules_python that sets PYTHONHOME does work around this problem and I'm able to successfully build. But it's not clear to me what other problems that might cause, and it's probably not the right solution

## 🔬 Minimal Reproduction

Any bazel repository using the pip extension should reproduce this on windows. For example, in https://github.com/protocolbuffers/protobuf, you can run:
`bazel test //python/google/protobuf/internal/numpy:numpy_test`

Note: you'll have to edit `python/requirements.txt` to not have any `<` symbols due to a separate bug I'll be filing another issue about.

## 🔥 Exception or Error

See description above. The error is from a corrupted python environment and not particularly helpful on its own

## 🌍 Your Environment

**Operating System:** Windows
**Output of `bazel version`:** Reproduces with Bazel 7 and 8
**Rules_python version:** 1.6.0

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with the pip extension's repository_ctx.execute call that derives PYTHONHOME, then reproduce on Windows using the protobuf target //python/google/protobuf/internal/numpy:numpy_test. Compare the command output with the intended Python path and verify that PYTHONHOME contains only the path, without the prompt or command text; confirm the reproduction succeeds with the affected rules_python versions.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python
領域
build-system
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。