bazel-contrib / bazel-contrib/rules_python

Allow py_wheel to use analysis phase information for attributes

未关闭
#3,162 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Starlark
星标
688
派生
721
平均合并
15 小时 7 分钟
30 天内合并 PR
76

描述

# 🚀 feature request

### Relevant Rules

`py_wheel`

### Description

When building a wheel with `py_wheel`, some attributes are closely tied to the Python runtime the wheel is intended for. For example, building a wheel with a C extension can require a `python_tag` value that has the python version as part of the abi tag.

Because e.g. `py_wheel.python_tag` takes a string, the only way to pass a value is to use a select() expression to map some condition to a raw string. This is tedious, to say the least. It's also problematic for constructing the `cp39` string -- there's no flag that captures the runtime implementation name ("cp"), so creating a select for this is tough (though, still possible with some tricks, see below).

I _think_ a workaround here is to combine toolchain lookup with FeatureFlagInfo. Have a custom rule look up the toolchain and return e.g. implementation_name in FeatureFlagInfo. Have a config_setting map that to true/false. Have a select() expression map the config setting to e.g. "cp39". Complicated and verbose, but I think it would work.

### Describe the solution you'd like

It'd be better if py_wheel either inferred the values from the toolchain, or provided a way to feed analysis phase information in for value.

The loose idea I have is to have an label attribute that accepts e.g. PyWheelInfo provider, and then users can populate that with what they choose. We'd provide a default impl that did the common thing.

贡献指南

打开贡献指南

调研方向

从 py_wheel 规则开始,重点关注 python_tag 以及这里描述的分析阶段工具链信息。确定推断还是 PyWheelInfo 输入更适合支持运行时派生的属性;完成的标准是用户可以提供实现/版本标签等值,而无需使用当前冗长的 select() 变通方案。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
build-system
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。