bazel-contrib / bazel-contrib/rules_python
Allow py_wheel to use analysis phase information for attributes
- Lenguaje dominante
- Starlark
- Estrellas
- 688
- Forks
- 721
- Merge medio
- 15 h 7 min
- PR fusionados (30 d)
- 76
Descripción
# 🚀 feature request
### Relevant Rules
`py_wheel`
### Description
When building a wheel with `py_wheel`, some attributes are closely tied to the Python runtime the wheel is intended for. For example, building a wheel with a C extension can require a `python_tag` value that has the python version as part of the abi tag.
Because e.g. `py_wheel.python_tag` takes a string, the only way to pass a value is to use a select() expression to map some condition to a raw string. This is tedious, to say the least. It's also problematic for constructing the `cp39` string -- there's no flag that captures the runtime implementation name ("cp"), so creating a select for this is tough (though, still possible with some tricks, see below).
I _think_ a workaround here is to combine toolchain lookup with FeatureFlagInfo. Have a custom rule look up the toolchain and return e.g. implementation_name in FeatureFlagInfo. Have a config_setting map that to true/false. Have a select() expression map the config setting to e.g. "cp39". Complicated and verbose, but I think it would work.
### Describe the solution you'd like
It'd be better if py_wheel either inferred the values from the toolchain, or provided a way to feed analysis phase information in for value.
The loose idea I have is to have an label attribute that accepts e.g. PyWheelInfo provider, and then users can populate that with what they choose. We'd provide a default impl that did the common thing.
Guía de contribución
Línea de trabajo
Comienza por la regla py_wheel, centrándote en python_tag y en la información de la toolchain de la fase de análisis descrita aquí. Determina si la inferencia o una entrada PyWheelInfo permite admitir mejor los atributos derivados del tiempo de ejecución; se considera terminado cuando los usuarios pueden proporcionar valores como la etiqueta de implementación/versión sin la actual solución alternativa verbosa con select().
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- build-system
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100