aws / aws/sagemaker-python-sdk

`kms_key` in `sagemaker.processing.Processor` should default to `output_kms_key`

Đang mở
#4,874 1 bình luận 0 reaction 1 người được giao Được @pintaoz-aws nhận Xem trên GitHub
component: processing type: bug
Ngôn ngữ chính
Python
Star
2.3k
Fork
1.3k
Merge trung bình
1 ngày 22 giờ
Pull request đã merge (30 ngày)
35

Mô tả

**Describe the bug**
The `kms_key` used to [encrypt either the user code file or local inputs when uploading to S3](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/processing.py#L367-L434) should default to `output_kms_key`.

This would align the behaviour of with `sagemaker.estimator.Estimator` where `output_kms_key` is used to [encrypt the tar'd user training code when uploading to S3](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/estimator.py#L990-L1054).

Also, since `output_kms_key` is resolved from the config it means that `kms_key` can inherit this default from the config.

**To reproduce**
A clear, step-by-step set of instructions to reproduce the bug.
The provided code need to be **complete** and **runnable**, if additional data is needed, please include them in the issue.

**Expected behavior**
The `kms_key` should default to `output_kms_key`. This can be implemented in either:

- [`sagemaker.processing.Processor._normalize_args`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/processing.py#L284-L325)
- [`sagemaker.processing.Processor._normalize_inputs`](https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/processing.py#L367-L434)

**Screenshots or logs**
If applicable, add screenshots or logs to help explain your problem.

**System information**
A description of your system. Please provide:
- **SageMaker Python SDK version**: v2.232.0
- **Framework name (eg. PyTorch) or algorithm (eg. KMeans)**: N/A
- **Framework version**: N/A
- **Python version**: 3.10
- **CPU or GPU**: CPU
- **Custom Docker image (Y/N)**: N/A

**Additional context**
Add any other context about the problem here.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.