aws / aws/sagemaker-python-sdk

sagemaker.image_uri.retrieve "container_version" parameter does not work as expected

Đang mở
#3,702 0 bình luận 0 reaction 1 người được giao Được @martinRenou nhận Xem trên GitHub
component: utility apis type: bug
Ngôn ngữ chính
Python
Star
2.3k
Fork
1.3k
Merge trung bình
1 ngày 22 giờ
Pull request đã merge (30 ngày)
35

Mô tả

**Describe the bug**
This API doc https://sagemaker.readthedocs.io/en/stable/api/utility/image_uris.html#sagemaker.image_uris.retrieve states that there is a parameter called "container_version" that can be used to retrieve a particular DLC. However, with certain versions, it creates an invalid image URI.

**To reproduce**
A clear, step-by-step set of instructions to reproduce the bug.

```
>>> import sagemaker
>>> sagemaker.image_uris.retrieve('pytorch', 'us-west-2', version='1.12', image_scope="inference", instance_type='ml.p3.8xlarge', container_version='1.1')

'763104351884.dkr.ecr.us-west-2.amazonaws.com/pytorch-inference:1.12-gpu-py38-1.1'
```

The above image URI does not exist, even though there is a 1.1 version of the container. Image URIs for v1.1 are included here:

https://github.com/aws/deep-learning-containers/releases/tag/v1.1-pt-sagemaker-1.12.1-inf-py38

**Expected behavior**
Expected behavior would be for the function to return a valid image URI with container version for the given framework from here - https://github.com/aws/deep-learning-containers/releases/tag/v1.1-pt-sagemaker-1.12.1-inf-py38

**Additional context**
It make not make sense to have this parameter, as there are likely only a few use cases where a user would specify the container version and not just reference the image URI directly. This could be useful for major version pinnings, but unfortunately as constructed, it would not retrieve the correct image URI.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.