Bug: XRay SDK doesn't support pg8000 native driver
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 339
- フォーク
- 147
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
Summary
pg8000 comes with two APIs, the pg8000 native API and the DB-API 2.0 Standard API (PEP-0249) and the XRay SDK fails to capture SQL segments when using the pg8000 native API.
Explanation, code example and output
When working with the pg8000 native API, customers initialize a connection using pg8000.native.Connection and xray is unable to intercept and wrapper this because in this line it always considers pg8000.connect and not pg8000.native.Connection. Also, when using pg8000 native API the connection instance doesn't have cursor, all the queries are executed directly using run command.
Check this code example:
from urllib.parse import quote_plus
import pg8000.native
from aws_xray_sdk.core import xray_recorder
from aws_xray_sdk.core import patch_all
# Initialize X-Ray
xray_recorder.configure(service='MyPostgresApp')
patch_all()
@xray_recorder.capture('connect_to_db')
def connect_to_db():
try:
host = "MYHOST"
user = "MYUSER"
database = "MYDATABASE"
password = "MYPASSWORD"
conn = pg8000.native.Connection(
database=database,
user=user,
password=password,
host=host,
port=5432,
ssl_context=True
)
return conn
except Exception as e:
print(f"Error connecting to database: {e}")
return None
@xray_recorder.capture('query_db')
def query_db(conn):
try:
results = conn.run("SELECT * FROM public.todos LIMIT 5")
return results
except Exception as e:
print(f"Error querying database: {e}")
return None
def main():
with xray_recorder.in_segment('main_function'):
conn = connect_to_db()
if conn:
results = query_db(conn)
if results:
print("Query results:", results)
conn.close()
if __name__ == "__main__":
main()
This creates the json below and we see that there is no run subsegment in the query_db segment because XRAY cannot patch this driver when using native Connection.
{
"id":"caeb26df6fe242ed",
"name":"main_function",
"start_time":1736462563.884077,
"in_progress":false,
"aws":{
"xray":{
"sdk":"X-Ray for Python",
"sdk_version":"2.14.0"
}
},
"subsegments":[
{
"id":"981eb724c5369158",
"name":"connect_to_db",
"start_time":1736462563.884105,
"parent_id":"caeb26df6fe242ed",
"in_progress":false,
"trace_id":"1-678050e3-fbec3813f4280021b9069ff5",
"type":"subsegment",
"namespace":"local",
"end_time":1736462564.930994
},
{
"id":"eb5a8872a770eacd",
"name":"query_db",
"start_time":1736462564.931169,
"parent_id":"caeb26df6fe242ed",
"in_progress":false,
"trace_id":"1-678050e3-fbec3813f4280021b9069ff5",
"type":"subsegment",
"namespace":"local",
"end_time":1736462565.3793
}
],
"trace_id":"1-678050e3-fbec3813f4280021b9069ff5",
"service":{
"runtime":"CPython",
"runtime_version":"3.12.8"
},
"end_time":1736462565.3813171
}
Solution
I created a small PoC locally and made it work by adding a new method to wrap native.Connection and creating a new class called XRayTracedNative to intercept the run method and then be able to create the subsegment.
*the names are just suggestions, you can choose whatever name you want.
Please let me know if you are interested in a PR to implement this and I can work.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まず aws_xray_sdk/ext/pg8000/patch.py を読み、特に pg8000.connect の既存の処理を確認してから、issue で説明されている pg8000.native.Connection とその run エントリーポイントを比較します。native 接続と run 呼び出しによって、Standard API の経路と同様にキャプチャされた X-Ray SQL サブセグメントが生成されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python
- 領域
- databases
- issue の種類
- バグ
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 45/100