aws / aws/aws-encryption-sdk-python

Fix max frame size

Open
#130 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
Python
Stars
255
Forks
92
Avg merge
2d 17h
Merged PRs (30d)
2

Description

## Problem

Per the message format specification, the frame size is an unsigned 32-bit integer. No other limits are set on this value. As such, the max frame size is `2^32 - 1`, not `2^31 - 1` as currently defined. It looks like this snuck in as an implementation detail from the Java client, where the frame size is limited by `MAX_INT`.

## Solution

Fix the defined value to be `2^32 - 1` and add tests that verify that frames of size `2^31 - 1 < frame_size <= 2^32 - 1` work correctly.

Contributor guide

Open the contributing guide

Research direction

Start by locating the defined maximum frame size and the tests covering frame encoding, decoding, or validation. Verify the current boundary behavior, then update the value and add coverage for sizes above 2^31 - 1 through 2^32 - 1; done means those frames work correctly and the existing tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.