aws / aws/aws-encryption-sdk-python
Fix max frame size
- Vorherrschende Sprache
- Python
- Sterne
- 255
- Forks
- 92
- Ø Merge
- 2 T. 17 Std.
- Gemergte PRs (30 T.)
- 2
Beschreibung
## Problem
Per the message format specification, the frame size is an unsigned 32-bit integer. No other limits are set on this value. As such, the max frame size is `2^32 - 1`, not `2^31 - 1` as currently defined. It looks like this snuck in as an implementation detail from the Java client, where the frame size is limited by `MAX_INT`.
## Solution
Fix the defined value to be `2^32 - 1` and add tests that verify that frames of size `2^31 - 1 < frame_size <= 2^32 - 1` work correctly.
Beitragsleitfaden
Rechercherichtung
Start by locating the defined maximum frame size and the tests covering frame encoding, decoding, or validation. Verify the current boundary behavior, then update the value and add coverage for sizes above 2^31 - 1 through 2^32 - 1; done means those frames work correctly and the existing tests pass.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- security
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 45/100