aws / aws/aws-codeguru-cli

`--commit-range` doesn't restrict the recommendations to changed files in that range

未关闭
#35 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Java
星标
23
派生
13
PR 合并指标
30 天内没有已合并 PR

描述

### Issue
When I run the cli command to get a security scan for a given commit range, it includes recommendations across the entire package rather than just the specified commit range.

### Steps to reproduce
1. Run `aws-codeguru-cli --root-dir . --profile --mode security --commit-range HEAD^:HEAD`
2. Observe the the file at `code-guru/recommendations.json` includes recommendations across your entire package.

### Expected Result
Only include recommendations that are part of the diff within the commit range.

### Notes
I tried removing the commit range and noticed that the output is identical which makes me think that the flag is ignored.

This seems related to #9 but I wasn't able to validate the output of the jobs mentioned in that query.

贡献指南

打开贡献指南

调研方向

使用和不使用 --commit-range 运行报告的 aws-codeguru-cli 命令,然后比较 code-guru/recommendations.json。跟踪 --commit-range 的入口点并检查相关的 issue #9;完成的标准是 recommendations.json 仅包含指定提交范围内发生更改的文件的建议。

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
cli
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。