aws / aws/aws-codeguru-cli

`--commit-range` doesn't restrict the recommendations to changed files in that range

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
23
Forks
13
PR merge metrics
No merged PRs in 30d

Description

### Issue
When I run the cli command to get a security scan for a given commit range, it includes recommendations across the entire package rather than just the specified commit range.

### Steps to reproduce
1. Run `aws-codeguru-cli --root-dir . --profile --mode security --commit-range HEAD^:HEAD`
2. Observe the the file at `code-guru/recommendations.json` includes recommendations across your entire package.

### Expected Result
Only include recommendations that are part of the diff within the commit range.

### Notes
I tried removing the commit range and noticed that the output is identical which makes me think that the flag is ignored.

This seems related to #9 but I wasn't able to validate the output of the jobs mentioned in that query.

Contributor guide

Open the contributing guide

Research direction

Run the reported aws-codeguru-cli command with and without --commit-range, then compare code-guru/recommendations.json. Trace the --commit-range entry point and review related issue #9; done means recommendations.json contains only recommendations for files changed in the specified commit range.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.