aws / aws/aws-codeguru-cli

`--commit-range` doesn't restrict the recommendations to changed files in that range

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
23
Forks
13
PR merge metrics
No merged PRs in 30d

Description

### Issue
When I run the cli command to get a security scan for a given commit range, it includes recommendations across the entire package rather than just the specified commit range.

### Steps to reproduce
1. Run `aws-codeguru-cli --root-dir . --profile --mode security --commit-range HEAD^:HEAD`
2. Observe the the file at `code-guru/recommendations.json` includes recommendations across your entire package.

### Expected Result
Only include recommendations that are part of the diff within the commit range.

### Notes
I tried removing the commit range and noticed that the output is identical which makes me think that the flag is ignored.

This seems related to #9 but I wasn't able to validate the output of the jobs mentioned in that query.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.